Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implementing the base @scope #425

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: implementing the base @scope #425

wants to merge 2 commits into from

Conversation

yisibl
Copy link
Contributor

@yisibl yisibl commented Feb 12, 2023 •
edited
Loading

@yisibl yisibl force-pushed the add-base-scope branch 4 times, most recently from ce36c1b to 5d37f2d Compare February 12, 2023 06:23
@devongovett
Copy link
Member

Do you think we should put this behind a flag like we have for nesting since the spec is still draft and potentially changing? Also since it is not fully implemented yet.

@yisibl
Copy link
Contributor Author

yisibl commented Feb 13, 2023

Ok, I've added a flag to disable it by default.

But I can't run yarn website:build locally, can you take a look?

@devongovett devongovett mentioned this pull request Sep 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yisibl @devongovett